Client rewrite β-testing

[Garlicman]

Any UI options in the pipeline?

[loftar]

Any UI options in the pipeline?

Not as part of this rendering rewrite, no. Not saying there shouldn't be any, but that is a completely unrelated topic and should be in its own thread. (If you're referring to UI scalability, the last major discussion on that topic took place here.)

I went ahead and started looking into it myself. Looks like it is a known issue with jogl, and scheduled to be fixed in 2.4

https://jogamp.org/bugzilla//show_bug.cgi?id=1374

Indeed, I suspected that might be the case. Jogl 2.4 has been in the pipe for quite some time, though, and I wonder if it will be released anytime soon. I wonder whether it might be reasonable to ship a version compiled from Git sources. It's hard to say without knowing how stable their master branch is.

[Garlicman]

Ok, thanks. Because one of the huge reasons I'm using a different client is it allows me to increase the font size or change the font - don't want to kill my eyes and/or neck playing Haven. You guys aren't probably looking to expand the playerbase significantly, but if you would we doing that, some degree of UI accessibility would be an issue.

[Hadehariast]

Not really a major issue, but I've noticed occasionally that an animal gob won't get deleted when I walk out of render which then keeps it there until I log out and back in. No error message and I'm not really sure what triggers it as i'm never doing anything special aside from walking around.

I believe this is the same thing which my partner has encountered a few times this morning. We've had several animals become "duplicated" on screen. The duplicate has remained frozen. Right-clicking-->Inspect on the duplicate directs you towards the actual animal which it has duplicated. She's encountered it with both a cow and two sheep. Logging out and logging back in has removed the duplicates. I'm afraid I don't know how to do heap dump.

[Spacecpp]

I have been playing with the new client since yesterday. While the map loading had speed-up a lot, there are several new bugs like:
-when I unequip an item it's outline still appears at equipment window
-player models sometimes disappear complety or show at an outdated location, the animation is frozen in place
-arrows pointing to party members sometimes won't show or freeze regardless of camera angle
-frequent jittering (noticeable when walking)

[loftar]

I'm afraid I don't know how to do heap dump.

There are several ways. If you want to try, some of them are listed here. I recommend method #1 (jmap) or #4 (VisualVM) on that list particularly, but it might be that for either one you need not just Java, but the full JDK. I'm not entirely sure.

[loftar]

-when I unequip an item it's outline still appears at equipment window

I know, it's still listed in the OP.

-player models sometimes disappear complety or show at an outdated location, the animation is frozen in place

I strongly suspect that's an instance of the lingering-animals bug being discussed just above.

-arrows pointing to party members sometimes won't show or freeze regardless of camera angle

Didn't know about that one, will have to check.

-frequent jittering (noticeable when walking)

I suspect you're using Java 8, right? Its garbage collector seems to have moments of interacting weirdly with new client. I believe this is largely fixed on Java 9 and newer, but you may want to try to see if turning off parallel process (console command :par off) fixes it, as I've noticed it sometimes creating particularly weird GC interactions (which is why it didn't use to be on by default).

[mvgulik]

Finally, no more typing of :hz & :bghz all the time.



Sliders:
It might be a nice user-friendly improvement if sliders where giving some focus behavior ... so one could have some alternative way to set/adjust them.
(the default trial & error mouse-sliding become a bit of a nuisance over time)
(I know. Not losing/blocking other game controls, while a slider would have focus, is a important detail ...) ... (Mmm, additional left/right click buttons for sliders perhaps. No key-binds needed that way.)


Probably related to that DPI stuff from some posts back.



Zoom-ing:
When zooming in/out (with mouse-scroll-wheel), the client has a tendency to freeze for a short moment. (animations, mouse cursor, ...)
The time the client freezes seems directly related to the number of zoom commands that where given at that moment.
If (for example) your already fully zoomed-in, and give the mouse-scroll wheel an additional whirl in the zoom-in direction (ie: Fast N times trying to zoom-in). The longer the time is that the client will temporary freeze. (could easily be up to a second, with a moderate whirl on the mouse-scroll-wheel, in my case)

[Artemiswhb]

What is the point of passing GSettings around as a state? Maybe I'm blind but it seems like nothing more than a class for settings?

Specifically here: https://github.com/dolda2000/hafen-client/blob/render/src/haven/PView.java#L96

[Spacecpp]

I suspect you're using Java 8, right? .

My java control panel says version 9.0.1 amd64