another boat bug?

[pMule]

I noticed that boats (and possibly other items, like carts) are being reset after server restart to facing south direction regardless from where they were pointed before.
Aside of being minor annoyance, when boat that was possible to embark/disembark before isn't anymore, there are also cases when overlaying sprites matter (for example hiding boat behind something). It is also possible that this can contribute to whole range of crash+unable to log-in bugs where due to running the spawn spot is not whee boat is anymore?

[Peter]

That's a good eye, and worth noting, but as far as I know boat direction is purely graphical. I think that what happens in a crash is that people log off, dropping any containers and thus being unable to log in where that was.

[Phazorx]

That's a good eye, and worth noting, but as far as I know boat direction is purely graphical. I think that what happens in a crash is that people log off, dropping any containers and thus being unable to log in where that was.

Well, considering that boat has 2x2 tiles hitbox and capable of carrying 2 people rotation can matter, but that of course depends on implementation withing code...

[jorb]

That's a good eye, and worth noting, but as far as I know boat direction is purely graphical. I think that what happens in a crash is that people log off, dropping any containers and thus being unable to log in where that was.

Well, considering that boat has 2x2 tiles hitbox and capable of carrying 2 people rotation can matter, but that of course depends on implementation withing code...

The boat uses the same bounding box regardless of how it faces.

[Potjeh]

Which makes it a bitch to put it down and to walk around it. Could you change that, please?

[Chakravanti]

Which makes it a bitch to put it down and to walk around it. Could you change that, please?

Yeah, seriously, It has MAJOR bounding box issues.

[Phazorx]

That's a good eye, and worth noting, but as far as I know boat direction is purely graphical. I think that what happens in a crash is that people log off, dropping any containers and thus being unable to log in where that was.

Well, considering that boat has 2x2 tiles hitbox and capable of carrying 2 people rotation can matter, but that of course depends on implementation withing code...

The boat uses the same bounding box regardless of how it faces.

Bounding box is th same, i never questioned that, but say there are two players onboard and boat is heading north, how are player coordinates stored? are they relative to the boat, or position in vehicle (to determine who is driver and who is passenger) is stored separately? Does it matter that if boat switches direction to heading south it appears that players exchange their places geometrically-visually.
I doubt that game places boat on all tiles it occupies, it is more logical to use one of tiles as key and calculate occupied space based on rotation, but if rotation property is lost - it could result in boat using different 4 tiles that these which were used before.

[sabinati]

there are two spots in a boat. if you're in the 1st spot and the boat rotates, you're still in the first spot.

[Phazorx]

there are two spots in a boat. if you're in the 1st spot and the boat rotates, you're still in the first spot.

that is true in case if rotation comes as an action from a player and server normally handles it by rotating the boat and doing all other necessary calculations about players whereabouts (thus, when player exits or server goes through shutdown - whatever is current stored to be recalled when player comes back online). We all know what happens if a another item is placed at where the player was logged off, boats are an exclusion to that case, but what if player position how it was stored does not match proper boat part when it is recalled due to boat being rotated into "default direction"?

[loftar]

I doubt that game places boat on all tiles it occupies, it is more logical to use one of tiles as key and calculate occupied space based on rotation, but if rotation property is lost - it could result in boat using different 4 tiles that these which were used before.

The server save no such thing at all "per tile". Rather it saves the boat object and its coordinate; the coordinates of the bounding box is relative to that coordinate and is therefore entirely unaffected by the boat's rotation. The rotation is, indeed, purely visual.

Bounding box is th same, i never questioned that, but say there are two players onboard and boat is heading north, how are player coordinates stored? are they relative to the boat, or position in vehicle (to determine who is driver and who is passenger) is stored separately? Does it matter that if boat switches direction to heading south it appears that players exchange their places geometrically-visually.

While the player coordinates are stored, they are completely ignored when logging in back into a boat. What is saved is the identity of the boat itself, and when logging back into a boat, the boat is simple requested to accept the player. If there is a spot free in the boat, then, the player receives that spot.