Weirdness with Chicken food & qualities megathread.

[Avu]

Two decimals should be enough. It will lessen the situations where the averages fuck up by 100 times.

[Procne]

And then have bug reports asking why qualities behave in unexpected manners due to unforseen roundings?

That's what you are having NOW

Moreover preventing players from actually determining their qualities?

That's what you have now as well when players drop a bunch of various quality stuff in and are unable to determine the outcome by simply averaging numbers. Unless by "determining" you meant "most likely it will be of lowest from available qualities in all three components"

[Shiala]

I think the other thing people tend to forget is that just because two things average out to the same number doesn't mean they're the same quality. For example, you have carrots that are 15/25/10 and beets that are 25/10/15, the number that shows as the average will be the same but they are not actually the same. Combining those two together will result in a lower quality end product.

[shubla]

I have almost q1 chickens even thought im sure their food and water is lot better

[sabinati]

Two decimals should be enough. It will lessen the situations where the averages fuck up by 100 times.

1 should really be fine

[Granger]

Solution to rounding problem:
Store the quality averages as fucken floats.
The end.

And keep the player informed of the decimal points? "Quality 12.2482775/15.2338/12.23"?

Other solution to the rounding problem:

Store the amount, and the sum of the quality.
The moment you reduce the amount, do

Code: Select all

quality_removed = sum_quality/items_in
sum_quality -=  quality_removed*items_removed
items_in -= items_removed

You can do that as integer, in case (sum_quality/items_in) rounds down it'll keep the fraction in sum_quality to be taken out later.
Only thing to keep in mind is to not allow items_removed > items_in/2 or it could be exploited to deterministicly raise the q of the items remaining.

[MagicManICT]

No need to store all the values when the remainder (modulus) can be stored and used in the calculation. It's an old optimization to avoid floating point calculations for a few extra bytes of memory. I think it used to be something like 100x faster before FPUs were common in computers.

[Granger]

No need to store all the values []

My suggestion is to store the total sum of the values, not a list of them.

[Itanu]

I'm guessing this hasn't been fixed yet. I would say its a fairly high priority, considering that it also probably happens to fuel in every furnace, water in barrels, and, for that matter, any liquid at all. Whilst swill is the most broken and most noticeable, a rework of the whole system is probably in order. Volume and quality aggregates would probably be the easiest way of doing it, conserving all the information, but using a rounded down version of Qtotal/volume for any recipes/uses.
pls this is more important than adding lettuce.

[MagicManICT]

With the change to how qualities are tracked a few weeks ago, has anyone had issues with fodder qualities?

(Just noticed this was still up here and wasn't taken down.)