Rennet seems to ignores water quality

[Sevenless]

Another one of those "Is it a bug or a balance fix?" type things, but anyway. V8 vinegar, V9 maw, V17 cauldron, V50 water gives V13 rennet. It seems like the water quality is completely ignored. Since (to my knowledge) all other active boil items incorporate water quality into their formula this seems like a bug.

[jorb]

Will look at it.

[jorb]

The weight for the cauldron in recipes like this is only 1/4, and that is the average of the water and the cauldron. Working as intended.

[lachlaan]

What's the weight of the cauldron tho vs the water itself? Because if it were half each you'd still get 14 bit rennet even if both maw and vinegar were bit 8 and the average of cauldron and water rounded down to 33.

[jorb]

What's the weight of the cauldron tho vs the water itself? Because if it were half each you'd still get 14 bit rennet even if both maw and vinegar were bit 8 and the average of cauldron and water rounded down to 33.

That is actually odd, yeah. It should have been 14 if the numbers were as reported, and that is also what we get when testing this.

Could perhaps be this problem. If so it is unclear what causes it.

[Granger]

Could perhaps be this problem. If so it is unclear what causes it.

In that thread you say

I think we can basically confirm this bug, and we suspect that it may be due to floating point rounding errors, somehow.

Why does Loftar use floating point anyway instead of an integer (using the LSBits as fraction)?
Or why round on every item added, instead of cumulating all quality points and doing a single divide+round at the end?