Yoink Pasta - Purus Pasta fork

[Undercio]

Found an error; not present in vanilla client.

Code: Select all

Exception in thread "Haven UI thread" java.lang.NullPointerException: Cannot read field "notify" because "conf" is null
        at haven.MiniMap$DisplayIcon.<init>(MiniMap.java:261)
        at haven.MiniMap.getCustomMapIcon(MiniMap.java:650)
        at haven.MiniMap.findicons(MiniMap.java:610)
        at haven.MiniMap.tick(MiniMap.java:228)
        at haven.Widget.tick(Widget.java:757)
        at haven.Widget.tick(Widget.java:757)
        at haven.GameUI.tick(GameUI.java:1244)
        at haven.Widget.tick(Widget.java:757)
        at haven.UI.tick(UI.java:217)
        at haven.GLPanel$Loop.run(GLPanel.java:384)
        at haven.JOGLPanel.run(JOGLPanel.java:252)
        at java.base/java.lang.Thread.run(Thread.java:833)

Only occurs when gobs enter UI range (sometimes). It wasn't occuring for a while, but it is now persisting. I've tried building it locally from source and it persists. Checking the included source, there is no null check for GobIcon.Setting passed to the class. Presumably there shouldn't be a case where a gobicon would have a null setting field.

Windows 11 AMD 64
java version "17.0.8" 2023-07-18 LTS
Java(TM) SE Runtime Environment (build 17.0.8+9-LTS-211)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.8+9-LTS-211, mixed mode, sharing)

Similiar error when playing with minimap icons... ive been trying to add some icons to display on minimap... now i cant play at all...

Exception in thread "Haven UI thread" java.lang.NullPointerException: Cannot read field "notify" because "conf" is null
at haven.MiniMap$DisplayIcon.<init>(MiniMap.java:261)
at haven.MiniMap.getCustomMapIcon(MiniMap.java:650)
at haven.MiniMap.findicons(MiniMap.java:610)
at haven.MiniMap.tick(MiniMap.java:228)
at haven.Widget.tick(Widget.java:757)
at haven.Widget.tick(Widget.java:757)
at haven.GameUI.tick(GameUI.java:1244)
at haven.Widget.tick(Widget.java:757)
at haven.UI.tick(UI.java:217)
at haven.GLPanel$Loop.run(GLPanel.java:384)
at haven.JOGLPanel.run(JOGLPanel.java:252)
at java.base/java.lang.Thread.run(Unknown Source)

Minimap Icons button from login menu -> options also crashes:

Exception in thread "Haven UI thread" java.lang.NullPointerException: Cannot read field "chrid" because "gameUI" is null
at haven.purus.map.MapOptionsWindow.<init>(MapOptionsWindow.java:15)
at haven.OptWnd.lambda$new$3(OptWnd.java:803)
at haven.Button.click(Button.java:163)
at haven.Button.mouseup(Button.java:220)
at haven.UI.mouseup(UI.java:535)
at haven.UIPanel$Dispatcher.dispatch(UIPanel.java:77)
at haven.GLPanel$Loop.run(GLPanel.java:365)
at haven.JOGLPanel.run(JOGLPanel.java:252)
at java.base/java.lang.Thread.run(Unknown Source)

[dor]

Hi.

Tried to make it work with automapper server but no luck. Any advice?
What I did:
- Installed server using this instructions: viewtopic.php?f=49&t=67298&start=10#p853436 (threre are some discrepancies, but I managed to make it work)
- in server admin added new user
- under this new user created new token
- added server address and token to client (see attachment, ip and token are edited, for obvious reasons)

There are two issues:
- most important one - no data in automapper server
- click on "Open" button leads to page with message "Client token not found", which is quite confusing, because token is correct.

There are not so many settings.. what could go wrong? )

[Bartekc8888]

Found an error; not present in vanilla client.
Only occurs when gobs enter UI range (sometimes). It wasn't occuring for a while, but it is now persisting. I've tried building it locally from source and it persists. Checking the included source, there is no null check for GobIcon.Setting passed to the class. Presumably there shouldn't be a case where a gobicon would have a null setting field.

Sorry about that, there was an old way to set up custom icons before vanilla added it. I removed it now in v1.1.1 in favor of vanilla icons.

Found an error; not present in vanilla client.
Minimap Icons button from login menu -> options also crashes:

The map settings needed scope of a user and before loggin in there were no user. But these settings shouldn't be needed anymore as I said above.

There are two issues:
- most important one - no data in automapper server
- click on "Open" button leads to page with message "Client token not found", which is quite confusing, because token is correct.

Try adding server port to the address. I know it works in browser automatically with port 80 but it needs it here
The open button is a leftover from previous implementation. This one does not validate token this way, i will probably change it to just open /map page

[dor]

Thx! Adding port seems kinda helping. Now I see these kind of messages in client console on start(when I login to the world, to be precise):

Code: Select all

collected 5 markers
processing 5 markers
processing 5 markers
scheduling marker upload


But I don't see anything on the server. No map updates, no players added to tracking selector and no players themselves. Both tracking and mapping enabled in client and mapping and uploading enabled for used map user. Are there anything else I'm missing?

[Bartekc8888]

Are there anything else I'm missing?

hmm, why did you use 1.1.1.1? Its a dns address
If server is on the same computer try localhost instead.
Also there might be some issues if you use multiple characters, ender mapper wasn't adjusted for that, so it may for example only show position of last character.

I should probably also add some logging for connection errors

[Noogia]

Anyone else getting a client freeze when they press the interface settings on the settings menu?

[dor]

Are there anything else I'm missing?

hmm, why did you use 1.1.1.1? Its a dns address
If server is on the same computer try localhost instead.
Also there might be some issues if you use multiple characters, ender mapper wasn't adjusted for that, so it may for example only show position of last character.

I should probably also add some logging for connection errors

I'm using my real address, just for screenshot I replaced it. Same as a token was edited for the screeenshot. When I click "Open", it leads to correct address, so it's fine here. But data is not there, for some reason. If you need a server for testing I can give you access, just write PM.
Let me know if there are any kind of data you need to debug this.

[khajios]

Mapping is working fine for me. I would guess there is some issue on the docker container side, but don't really know what you would need to look at there. I can cause a similar issue on my end by not mapping the /map directory, so that might be a place to look for an issue?

Wanted to bring up an issue I am running into along with my group.

Whenever we try and make a new character with the client, we get a black screen. We can either sign into a different character first, go back to character select, and then make a character successfully, or we can just make in the default client then change clients. Minor issue, but its happening to the 3 of us that I asked about it.

[dor]

Mapping is working fine for me. I would guess there is some issue on the docker container side, but don't really know what you would need to look at there. I can cause a similar issue on my end by not mapping the /map directory, so that might be a place to look for an issue?

What do you mean by "not mapping the /map directory"? Could you explain, please? It could be my issue, because I don't remember doing anything like that

[Bartekc8888]

1.1.2
Patched issue with mapper when creating new character
Add http code logging in mapper when it returns something else than 200
Add option to enable player marker upload
Corrupted markers are now skipped to fix an issue with marker upload

Whenever we try and make a new character with the client, we get a black screen. We can either sign into a different character first, go back to character select, and then make a character successfully, or we can just make in the default client then change clients. Minor issue, but its happening to the 3 of us that I asked about it.

I found an issue with mapper on new character creation but it instead froze ui for me so I'm not sure if it is the same issue

What do you mean by "not mapping the /map directory"? Could you explain, please? It could be my issue, because I don't remember doing anything like that

He probably meant docker volume mounted on host. I don't think it would cause that not working at all, maybe maps would not be preserved between restarts.
I just used this command to launch server and it is working fine for me locally:
docker run -v C:/Users/myUser/folderWithMaps:/map -p 8080:8080 andyleap/hnh-auto-mapper:v-4
replace path with real path

I also added response code logging if there is an error, maybe it will somehow help to find issue.