Well... it would need glass as well as a few buckets of water to keep the fishes up, as well as some kind of seeds as feed. It would work a bit like chikens, but with a bigger variety of fishes.
They dug a lot of them in medieval times. Aerial surveys show the way that villages moved around with new ponds being dug as the village center shifted and different fields were being worked.