Debugging woes: Small rollback

[loftar]

Well, this is frustrating. The last time I tried this server code, it crashed within hours on a double-free bug. Now I've been running for three days with ASan and it hasn't showed up.

I really doubt it, but perhaps some of the other fixes along the way permuted the bug away or something. I'm going to try to run it without ASan again and see what happens. I really doubt ASan could "mask" the real bug here, but I'm kind of running out of other ideas.

[loftar]

Lol, turns out there was a bug in the termination code also. Doesn't really matter since it just sends corrupted shutdown-timer information to clients the last thing that happens before they're disconnected, but still. :)

[Vladichka]

Well, this is frustrating. The last time I tried this server code, it crashed within hours on a double-free bug. Now I've been running for three days with ASan and it hasn't showed up.

I really doubt it, but perhaps some of the other fixes along the way permuted the bug away or something. I'm going to try to run it without ASan again and see what happens. I really doubt ASan could "mask" the real bug here, but I'm kind of running out of other ideas.

Well, looks like it didn't take long

[loftar]

Well, looks like it didn't take long

Nah, as I mentioned, that was a bug when shutting down the still ASan'd server.

[xyzzy57]

Well, this is frustrating. The last time I tried this server code, it crashed within hours on a double-free bug. Now I've been running for three days with ASan and it hasn't showed up.

I really doubt it, but perhaps some of the other fixes along the way permuted the bug away or something. I'm going to try to run it without ASan again and see what happens. I really doubt ASan could "mask" the real bug here, but I'm kind of running out of other ideas.

Dynamic memory abuse bugs are a real b*tch. You have my sympathy. Good luck.

[MightySheep]

Fixing bugs is boring why don't u add some new bugs to the game instead

[Robben_DuMarsch]

Gigantic underground beetle that is like bear sized and very scary/stronk.
Tell Jorb we want bugs/beetles instead of birbs.

[vatas]

Gigantic underground beetle that is like bear sized and very scary/stronk.
Tell Jorb we want bugs/beetles instead of birbs.

[xyzzy57]

So was this latest crash the one you'd been waiting for? Inquiring minds really want to know.

[loftar]

It was indeed. I had been cleaning up parts of the connection code a while ago, and accidentally left a line that transmitted the error message for old clients twice, but using the same message buffer, leading to it getting freed twice. The first time it happened, I thought it looked like the double-free was a random dangling pointer getting freed in completely unrelated code (which is why I was running with ASan), but it turned out to be significantly simpler than that now that I got to examine it again.