Granger wrote:It took you
ten years to finally see the light and pull GPL client code from another user back into the official client,
improve usability. Ten fucking years... But, lo and behold, you
finally did it. So kudos for that, better late than never.
It's not like I've ever been principally opposed to merging code from others or anything. This was, frankly, the first thing I've ever been asked to merge, and unlike many other client modifications, it's also code that I felt that I could maintain, and it was also a very neatly formatted and packaged branch.
One of the things that people miss when they ask why I don't just adopt a custom client and maintain it as the default going forward, is that a lot of the code is written in a way that I don't want to maintain. And don't get me wrong, it's not that I "blame" custom client developers for writing their code that way, I get that they may have no other realistic choice in their situation, but nevertheless I want to, to the greatest possible extent, avoid client code that duplicates server-side mechanics. As another example, I generally don't want the client to be aware of the full range of some sort of content, like having complete lists of all kinds of trees, or similar things. Generally speaking, being the maintainer of the both the server and the client, I don't think it should be controversial that I have a different design philosophy from people who only maintain clients.