Game crush in bat and bee dungeon

[Alemir]

During the fight with violet bats which spawns new bats all team had a game crush

# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x000072a73617ad50, pid=14867, tid=14912
#
# JRE version: OpenJDK Runtime Environment (21.0.10+7) (build 21.0.10+7-Ubuntu-122.04)
# Java VM: OpenJDK 64-Bit Server VM (21.0.10+7-Ubuntu-122.04, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# C [libc.so.6+0x17ad50]
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -F%F -- %E" (or dumping to /home/oleksandr/Desktop/handh/core.14867)
#
# An error report file with more information is saved as:
# /home/-/Desktop/handh/hs_err_pid14867.log
[16,268s][warning][os] Loading hsdis library failed
#
# If you would like to submit a bug report, please visit:
# https://bugs.launchpad.net/ubuntu/+source/openjdk-21
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.

[Alemir]

We tried to log back but there were crushes till fight ends

[Alemir]

I have tested. It happens in all dungeons with many enemies. I fought with 7 or 9 badgers and game crashed.

[twinnnnn]

I’m playing on Ender client, and I also had this issue in the badger and bat dungeon. Especially when there are a lot of enemies.

[Dondy]

Cool. This happened to me too, roughly two days ago, except in my case it was a large swarm of green jellies coming out of loose rock and not in a dungeon at all.

I stopped crashing on log in once I logged in to find myself ko'd.

I am also on Ender.

[vatas]

Ender at this point is probably missing multiple crucial Loftar code merges. Not a bug.

As far as I know, Hurricane is the only public client that's currently up-to-date: viewtopic.php?f=49&t=76544

It recently even added the extended view for inventory (see items on a list) and "Sort All" -function.

Thank the guy who made the pull request, not me

I still think it's pretty useless

[twinnnnn]

Also remember such problem with big group of roe deer(

[inevitable]

Ender at this point is probably missing multiple crucial Loftar code merges. Not a bug.

As far as I know, Hurricane is the only public client that's currently up-to-date: viewtopic.php?f=49&t=76544

It recently even added the extended view for inventory (see items on a list) and "Sort All" -function.

Thank the guy who made the pull request, not me

I still think it's pretty useless

...except it happens on latest Hurricane also

[inevitable]

After a bit of analysis, the fix would be to remove the private field 'prep' here: https://github.com/dolda2000/hafen-clie ... t.java#L49

and eliminate usages of 'this.prep', so that cross-thread command accumulation is eliminated from process() and the possibility of init lambda arriving in a different frame than the draw that needs it is gone

You'll likely want to change prepare(buf) to take the target GLRender and appends into render.gl instead of this.prep; then there's no shared render to interleave into.

This eliminates 3 hazards:
Hazard 1 — this.prep is a shared, multi-writer render
Hazard 2 — buf.ro is published before the data store is written
Hazard 3 — Disposal can interleave with in-flight GLRenders

[Alemir]

More information: game crashes everytime I initiate a fight with >6 enemies
What is interesting: my teammate in the same fight had 5 enemies - he did not crash. I had 6 enemies - I crashed.