Illegal comparator among Coord2d methods

The worst monsters in the Hearthlands warp the fabric of space and time...
Post a reply

Illegal comparator among Coord2d methods

Postby SiO2 » Thu Oct 05, 2023 8:38 pm

Image
It is not just duplicate return. for A(1,1) and B(0,1) it will result in:
A.compareTo(B) == -1
B.compareTo(A) == 0
Which may case sneaky bugs. I hope you have not used it for something important.
Bronies for life /)
User avatar
SiO2
 
Posts: 223
Joined: Sun Feb 17, 2013 10:46 pm
Top

Re: Illegal comparator among Coord2d methods

Postby Glorthan » Fri Oct 06, 2023 5:38 am

submit a PR?
Glorthan
 
Posts: 1099
Joined: Tue Jun 11, 2013 4:33 pm
Top

Re: Illegal comparator among Coord2d methods

Postby SiO2 » Fri Oct 06, 2023 2:55 pm

Glorthan wrote:submit a PR?

I am sorry, a what?
Bronies for life /)
User avatar
SiO2
 
Posts: 223
Joined: Sun Feb 17, 2013 10:46 pm
Top

Re: Illegal comparator among Coord2d methods

Postby gravesmerch » Fri Oct 06, 2023 3:08 pm

this may just fix some old bugs I gave up on, gotta give it a try
gravesmerch
 
Posts: 333
Joined: Thu Sep 08, 2022 6:13 pm
Top

Re: Illegal comparator among Coord2d methods

Postby noindyfikator » Fri Oct 06, 2023 3:12 pm

SiO2 wrote:
Glorthan wrote:submit a PR?

I am sorry, a what?


Submit a pull request in haven repo
https://github.com/dolda2000/hafen-client

It's unlikely that they will merge it but worth a try
User avatar
noindyfikator
 
Posts: 1452
Joined: Fri Jul 15, 2011 11:10 am
Top
Post a reply

Return to Bugs

Who is online

Users browsing this forum: No registered users and 88 guests

Shoppe
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
cron