Ender Client

[mvgulik]

Almost identical to this "changing gear while + crafting window with ..." error.

This one: After increasing a single ability(survival in this case) multiple times in a row (about 5 time), while having the craft window open on "Stone axe".

(also using Pyrite spark to flip craft window away, to than flip it back to see new Stone axe soft-cap value. Probebly not needed, not checked.)

Code: Select all

java.util.ConcurrentModificationException
   at java.base/java.util.WeakHashMap$HashIterator.nextEntry(WeakHashMap.java:807)
   at java.base/java.util.WeakHashMap$KeyIterator.next(WeakHashMap.java:840)
   at java.base/java.lang.Iterable.forEach(Iterable.java:74)
   at haven.Makewindow.invalidate(Makewindow.java:325)
   at haven.Glob$CAttr.update(Glob.java:91)
   at haven.Glob.cattr(Glob.java:332)
   at haven.Session$RWorker.handlerel(Session.java:349)
   at haven.Session$RWorker.getrel(Session.java:371)
   at haven.Session$RWorker.run(Session.java:437)


(+Also triggered (of course) when fast-traveling (realm bonus change) (if related prerequisites are met).)

- - -
Previous error: (only last line value differs, by 2)

Code: Select all

java.util.ConcurrentModificationException
   at java.base/java.util.WeakHashMap$HashIterator.nextEntry(WeakHashMap.java:807)
   at java.base/java.util.WeakHashMap$KeyIterator.next(WeakHashMap.java:840)
   at java.base/java.lang.Iterable.forEach(Iterable.java:74)
   at haven.Makewindow.invalidate(Makewindow.java:325)
   at haven.Glob$CAttr.update(Glob.java:91)
   at haven.Glob.cattr(Glob.java:332)
   at haven.Session$RWorker.handlerel(Session.java:349)
   at haven.Session$RWorker.getrel(Session.java:371)
   at haven.Session$RWorker.run(Session.java:435)


[EnderWiggin]

Updated client with latest changes from loftar and (hopefully) fixed ConcurrentModificationException related to crafting window and updating relevant stats. What is weird I wasn't able to reproduce it localy before fix, probably some differences in JRE?
I've also found and fixed a bug that prevented opening of extended crafting window. Judging by the lack of reports of its brokenness I assume no one uses it?

[mvgulik]

I wasn't able to reproduce it localy before fix, probably some differences in JRE?

Could be. Currently running game on openjdk 11. (Linux, Mint (19))

Code: Select all

java -Xss1024k -Xms512m -Xmx1024m -jar updater-hafen.jar -U https://game.havenandhearth.com/hres/ game.havenandhearth.com

Code: Select all

$ java -version
openjdk version "11.0.9.1" 2020-11-04
OpenJDK Runtime Environment (build 11.0.9.1+1-Ubuntu-0ubuntu1.20.04)
OpenJDK 64-Bit Server VM (build 11.0.9.1+1-Ubuntu-0ubuntu1.20.04, mixed mode, sharing)

... extended crafting window ...

[mvgulik]

(hopefully) fixed ConcurrentModificationException related to crafting window and updating relevant stats

I for one can't trigger it anymore. So fix effective.
Thanks.

[EnderWiggin]

Try pressing ALT+X or rummage through additional actions (plus icon) in action menu in the bottom-right.

[crowe]

Try pressing ALT+X or rummage through additional actions (plus icon) in action menu in the bottom-right.

Didn't this client use to have wiki built into it?
What happen to that?

[mvgulik]

Didn't this client use to have wiki built into it?

No.

[EnderWiggin]

Try pressing ALT+X or rummage through additional actions (plus icon) in action menu in the bottom-right.

Didn't this client use to have wiki built into it?
What happen to that?

There was some wiki integration in the old (the 2.5D one, now legacy) haven-and-hearth client.

[mvgulik]

You did.
lol

Anyway.

I run into this odd displayed hit-/bounding-box case.
(actual in-game active hitbox area is conform the graphical image of the object)


Took a look at some other objects to see if it was something general, but without any definite result. (o wait ... except perhaps for the indoor wall hit-boxes )

Ender client, or resource file, issue ?

[EnderWiggin]

I run into this odd displayed hit-/bounding-box case.
(actual in-game active hitbox area is conform the graphical image of the object)

Ender client, or resource file, issue ?

At first I thought this to be a resource file issue (loftar gives no guarantee that hitbox layers are correct, especially old format ones, like smelter). But upon closer inspection I noticed that I draw old hitbox layers flipped on Y-axis (who new you need to invert y-coord from that layer?). Should be fixed now.