Game Development: Smoked 'Shroom

Announcements about major changes in Haven & Hearth.
User avatar
shubla
Posts: 13041
Joined: Sun Nov 03, 2013 11:26 am
Location: Finland

Re: Game Development: Smoked 'Shroom

Post by shubla »

loftar wrote:
czaper2 wrote:I sent a pull request with code changes for the client on github. I'm sure you'll get to it right after that guys pull request from 2015.
Sorry, I don't normally use Github at all, so if you want me to be aware of pull requests, you should probably tell me via some other means (like this). I'll make absolutely sure to apply your patch for a typo in an error message that never actually happens. :)

That being said, pull requests are quite inconvenient for me to apply, since most changes should normally be on the (internal) core branch rather than directly on the master branch. I'm not really sure how to get a pull request out of GitHub without having to apply it to the indicated branch.
https://patch-diff.githubusercontent.co ... ull/7.diff
https://patch-diff.githubusercontent.co ... ull/6.diff
Image
I'm not sure that I have a strong argument against sketch colors - Jorb, November 2019
http://i.imgur.com/CRrirds.png?1
Join the moderated unofficial discord for the game! https://discord.gg/2TAbGj2
Purus Pasta, The Best Client
User avatar
shubla
Posts: 13041
Joined: Sun Nov 03, 2013 11:26 am
Location: Finland

Re: Game Development: Smoked 'Shroom

Post by shubla »

loftar wrote:
czaper2 wrote:I sent a pull request with code changes for the client on github. I'm sure you'll get to it right after that guys pull request from 2015.
Sorry, I don't normally use Github at all, so if you want me to be aware of pull requests, you should probably tell me via some other means (like this). I'll make absolutely sure to apply your patch for a typo in an error message that never actually happens. :)

That being said, pull requests are quite inconvenient for me to apply, since most changes should normally be on the (internal) core branch rather than directly on the master branch. I'm not really sure how to get a pull request out of GitHub without having to apply it to the indicated branch.
Or possibly
https://patch-diff.githubusercontent.co ... ll/6.patch
https://patch-diff.githubusercontent.co ... ll/7.patch
Image
I'm not sure that I have a strong argument against sketch colors - Jorb, November 2019
http://i.imgur.com/CRrirds.png?1
Join the moderated unofficial discord for the game! https://discord.gg/2TAbGj2
Purus Pasta, The Best Client
nero1141
Posts: 51
Joined: Sat Feb 02, 2019 4:43 pm

Re: Game Development: Smoked 'Shroom

Post by nero1141 »

i think the smokres should have diferent color of smokre like tar kilns
Hrenli
Posts: 1169
Joined: Mon Mar 21, 2016 1:39 pm

Re: Game Development: Smoked 'Shroom

Post by Hrenli »

nero1141 wrote:i think the smokres should have diferent color of smokre like tar kilns
If you mean variable materials they are of course there. Silverfir smoker look like a portable loo...

Edit: darn, should have red better, you mean color of the smoke, not color of the smoker...
Too old to rock-n-roll, too young to die.
User avatar
Audiosmurf
Posts: 2944
Joined: Fri Jul 02, 2010 9:00 pm
Location: Ice Hell

Re: Game Development: Smoked 'Shroom

Post by Audiosmurf »

Hrenli wrote:
nero1141 wrote:i think the smokres should have diferent color of smokre like tar kilns
If you mean variable materials they are of course there. Silverfir smoker look like a portable loo...
Nah, he means the smoke from tar kilns comes out different colours, and is suggesting that it should be the same for smokers because they also explicitly care about what type of wood is burned.
jorb wrote:Audiosmurf isisis a fantastic poster/geniusracist and hisa meat/intellect is hugehomosexual
User avatar
kirion
Posts: 378
Joined: Sat Jul 31, 2010 11:45 pm

Re: Game Development: Smoked 'Shroom

Post by kirion »

Idk if the wood preference is based on real life, but if so this post might help?
https://pro-smoker.com/blogs/smoking-ti ... ring-chart
Or maybe i'm giving too much credit to jorbtar and they rolled dices for which tree did what
User avatar
Zyean
Posts: 246
Joined: Sat Apr 28, 2012 10:29 am

Re: Game Development: Smoked 'Shroom

Post by Zyean »

Can't put bollocks in them, is that intentional?
Joshk80k
Posts: 46
Joined: Sun Oct 16, 2011 1:15 am

Re: Game Development: Smoked 'Shroom

Post by Joshk80k »

Great patch, smoked meat is a really cool concept, I hope it translates to useful stuff for FEPs.
Ukhata
Posts: 712
Joined: Wed Jan 29, 2014 9:20 am

Re: Game Development: Smoked 'Shroom

Post by Ukhata »

Zyean wrote:Can't put bollocks in them, is that intentional?
you want to smoke dick then?
User avatar
Clemence
Posts: 447
Joined: Sat Mar 19, 2011 5:26 am

Re: Game Development: Smoked 'Shroom

Post by Clemence »

cool, i like the tooltips

Return to “Announcements”