Kami Client

[woo00154]

Hey Derkami,

It seems like the "fish" action is not acting properly in the client due to wrongly mapped button.

My current guess is that the categorizing logic for actions/menus under "Adventure" section is slightly messed up.
In fact, "fish" action is being categorized as a menu, and is expecting to open more submenu when you click it.
You can tell this is the case, since the menus and actions are each supposed to be sorted based on alphabet (menu first, actions next), but fishing is placed as a first item.

However, what doesn't make sense is that there is a workaround to this issue.
You can open up a different client (like Ard), add the "fish" action to the shortcut from there, and if you try the shortcut from Kami client, it works (though icon is invisible).
What I assume is happening is that only actions can be put on these shortcuts, and when "fish" action is put there from another client, that info is logged in server side.
Kami client attempts to search the menus list for its icon, but is unable to find it, making it look invisible.
However, when pressed, it sends the action request to the server, and it works normally.

I am suspicious of the MenuGrid.java file's line 400 logic, as it does recursion and checks whether if action has a parent or not.
But I can't tell from a quick look if there is a fault in the logic, and I also don't see why only fishing is handled differently. (possible memory corruption from somewhere?)
I might spend some time later to actually build and debug with some changes, but it's probably much faster for you since you have knowledge on this code already.

TL;DR
to Derkami: Please review MenuGrid.java line 400 or any sort/categorizing mechanism for the bottom right menu buttons. (Maybe GameUI.java, but not sure)
to Others: workaround "fish" bug by using another client (even default one works) and adding "fish" action to the shortcut.

[maze]

He's gone for awhile on vacation

[matheuswm]

Hey Derkami,

It seems like the "fish" action is not acting properly in the client due to wrongly mapped button.
-snib-

yep, can confirm it works and the workaround also works ,even though the hotkey button has no img i can still fish.

also, i'm getting really nasty gpu-sided hangups every couple seconds when inside buildings, especially with cheese/cupboards around. any ideas? it doesn't go up to 100% usage, nor does it throttle on ram or cpu (set 4gb for java), but it just hangs up on video regularly. Really weird.

[gravesmerch]

I'd check for spikes on default client, just to be sure

[Rewhite]

Game client is perfect, crashes with some toggle options is only thing that overshadow using it. I hope Kami will return from hiatus soon.

[derkami]

I'm back.
Just finished a merge marathon...

Expect some crashes, I'll fix whatever reports I'll get.

[Rewhite]

I'm back.
Just finished a merge marathon...

Expect some crashes, I'll fix whatever reports I'll get.

You are my hero

[Rewhite]

All extended shortcuts unbinded from panel and now impossible to rebind them

[derkami]

I'll have a look at this after work.

[derkami]

All extended shortcuts unbinded from panel and now impossible to rebind them

They are fixed. Update has no changelog info tho.