It is not just duplicate return. for A(1,1) and B(0,1) it will result in:
A.compareTo(B) == -1
B.compareTo(A) == 0
Which may case sneaky bugs. I hope you have not used it for something important.
-
SiO2
- Posts: 223
- Joined: Sun Feb 17, 2013 10:46 pm
Illegal comparator among Coord2d methods
It is not just duplicate return. for A(1,1) and B(0,1) it will result in:
A.compareTo(B) == -1
B.compareTo(A) == 0
Which may case sneaky bugs. I hope you have not used it for something important.
Bronies for life /)
-
Glorthan
- Posts: 1099
- Joined: Tue Jun 11, 2013 4:33 pm
Re: Illegal comparator among Coord2d methods
submit a PR?
-
SiO2
- Posts: 223
- Joined: Sun Feb 17, 2013 10:46 pm
Re: Illegal comparator among Coord2d methods
I am sorry, a what?Glorthan wrote:submit a PR?
Bronies for life /)
-
gravesmerch
- Posts: 521
- Joined: Thu Sep 08, 2022 6:13 pm
Re: Illegal comparator among Coord2d methods
this may just fix some old bugs I gave up on, gotta give it a try
-
noindyfikator
- Posts: 1478
- Joined: Fri Jul 15, 2011 11:10 am
Re: Illegal comparator among Coord2d methods
Submit a pull request in haven repoSiO2 wrote:I am sorry, a what?Glorthan wrote:submit a PR?
https://github.com/dolda2000/hafen-client
It's unlikely that they will merge it but worth a try
