Client crashes when placing down cupboards with decals

[Nightdawg]

Vanilla client, obviously.
It happens intermittently, when you lift a cupboard that has a decal on it, then right click to manually place it. If you can't reproduce it instantly, keep right clicking the cupboard, you eventually always crash.

Code: Select all

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
    at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
    at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
    at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
    at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
    at java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:567)
    at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:670)
    at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:160)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:174)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
    at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
    at haven.OCache.ctick(OCache.java:127)
    at haven.Glob.ctick(Glob.java:166)
    at haven.GLPanel$Loop.run(GLPanel.java:362)
    at haven.JOGLPanel.run(JOGLPanel.java:246)
    at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.util.ConcurrentModificationException
    at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1095)
    at java.base/java.util.ArrayList$Itr.next(ArrayList.java:1049)
    at haven.res.gfx.terobjs.items.decal.Decal$1.tick(decal.cjava:68)
    at haven.Gob$Overlay.tick(Gob.java:132)
    at haven.Gob.ctick(Gob.java:455)
    at haven.OCache.lambda$ctick$0(OCache.java:121)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
    at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
    at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1310)
    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1841)
    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1806)
    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

[sickaura]

happened to me with chests in w16

[Nightdawg]

From that stacktrace, I'm assuming it happens with anything that has a parchment decal on it

[Nightdawg]

bump

[axus]

Same crash happened to me (in Nightdawg's client). Forkin' workers!

[blayze4ever]

please fix. i move things around all the time and this happens too often. :<

[Regulus2424]

my plotmate is still stuck under cupboard to this very day , pls fix da bug

[AliExpressMerchant]

today in the morning I was moving into a new house, moving 200 cupboards with decal

for the sake of God

fix ur game

i needed to restart client like 50+ times

Code: Select all

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
	at java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:567)
	at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:670)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:160)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:174)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
	at haven.OCache.ctick(OCache.java:161)
	at haven.Glob.ctick(Glob.java:231)
	at haven.GLPanel$Loop.run(GLPanel.java:440)
	at haven.JOGLPanel.run(JOGLPanel.java:264)
	at java.base/java.lang.Thread.run(Thread.java:1583)

[Nightdawg]

Well since loftar won't fix the vanilla client, we fixed it like this in Hurricane I guess:
https://github.com/Nightdawg/Hurricane/ ... 94d73b5d61

But I'm assuming try-catching ConcurrentModificationException in ctick is very retarded and I really wish the core issue was fixed