Ender Client

[EnderWiggin]

Pushed fix for DeadlockException. Hopefully it works.

[Scilly_guy]

OverlappingFileLockException

Code: Select all

haven.Defer$DeferredException: haven.Defer$DeferredException: java.nio.channels.OverlappingFileLockException
	at haven.Defer$Future.get(Defer.java:196)
	at haven.Defer$Future.get(Defer.java:208)
	at haven.MiniMap$DisplayGrid.img(MiniMap.java:375)
	at haven.MiniMap.drawmap(MiniMap.java:454)
	at haven.MiniMap.drawparts(MiniMap.java:570)
	at haven.MiniMap.draw(MiniMap.java:585)
	at haven.MapWnd$View.draw(MapWnd.java:311)
	at haven.Widget.draw(Widget.java:754)
	at haven.Widget.draw(Widget.java:759)
	at haven.Frame.draw(Frame.java:88)
	at haven.MapWnd$ViewFrame.draw(MapWnd.java:160)
	at haven.Widget.draw(Widget.java:754)
	at haven.Widget.draw(Widget.java:759)
	at haven.Window.draw(Window.java:235)
	at haven.Widget.draw(Widget.java:754)
	at haven.Widget.draw(Widget.java:759)
	at haven.GameUI.draw(GameUI.java:1125)
	at haven.Widget.draw(Widget.java:754)
	at haven.Widget.draw(Widget.java:759)
	at haven.RootWidget.draw(RootWidget.java:83)
	at haven.UI.draw(UI.java:213)
	at haven.JOGLPanel.display(JOGLPanel.java:450)
	at haven.JOGLPanel.run(JOGLPanel.java:530)
	at java.lang.Thread.run(Unknown Source)
Caused by: haven.Defer$DeferredException: java.nio.channels.OverlappingFileLockException
	at haven.Defer$Future.get(Defer.java:196)
	at haven.MapFile$Segment$Cached.get(MapFile.java:969)
	at haven.MapFile$Segment$ByCoord.get(MapFile.java:1009)
	at haven.MapFile$Segment$ByCoord.get(MapFile.java:996)
	at haven.MapFile$View.addgrid(MapFile.java:1109)
	at haven.MiniMap$DisplayGrid$1.call(MiniMap.java:362)
	at haven.MiniMap$DisplayGrid$1.call(MiniMap.java:355)
	at haven.Defer$Future$1.run(Defer.java:158)
	at java.security.AccessController.doPrivileged(Native Method)
	at haven.Defer$Future.run(Defer.java:157)
	at haven.Defer$Worker.run(Defer.java:262)
Caused by: java.nio.channels.OverlappingFileLockException
	at sun.nio.ch.SharedFileLockTable.checkList(Unknown Source)
	at sun.nio.ch.SharedFileLockTable.add(Unknown Source)
	at sun.nio.ch.FileChannelImpl.lock(Unknown Source)
	at java.nio.channels.FileChannel.lock(Unknown Source)
	at haven.HashDirCache.lock2(HashDirCache.java:200)
	at haven.HashDirCache.lookup(HashDirCache.java:233)
	at haven.HashDirCache.fetch(HashDirCache.java:338)
	at haven.MapFile.sfetch(MapFile.java:70)
	at haven.MapFile.access$800(MapFile.java:39)
	at haven.MapFile$Grid.load(MapFile.java:661)
	at haven.MapFile$Segment.lambda$loadgrid$0(MapFile.java:985)
	... 4 more

[EnderWiggin]

As far as I can tell this is loftar's bug and he is aware of it, but currently doesn't know what is causing it. If you have any steps to reproduce it would help.

[Scilly_guy]

Fair enough, I must admit to not following bugs for the default client, so sorry for bringing it here. Sadly I don't know what is causing it.

[loftar]

As far as I can tell this is loftar's bug and he is aware of it, but currently doesn't know what is causing it. If you have any steps to reproduce it would help.

I haven't managed to conclusive determine what the cause is, but I have a guess, and I've pushed 08efa493 that should fix it if my guess is correct. I'll just have to see if reports of that error keep coming.

[EnderWiggin]

Updated both client version with loftar's fix + some minor fixes of my own.

[Spacecpp]

Hello, I just updated the client and there is some bugs:

* The icons at the attribute window are giant;
* Combat openings are barely visible, they went to top of the screen.

[EnderWiggin]

Updated client with merged loftar's code. Attributes are fine now, haven't checked combat yet.

[The_Witcher]

Hi Ender! need to lock drop from inventory, overcome with the ctrl key.

[EnderWiggin]

Hi Ender! need to lock drop from inventory, overcome with the ctrl key.

Can you explain in more detail?